Fix a bug in linear.symplectic._build_hyper_partner
#384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
dsvandet
approved these changes
Sep 19, 2023
There was a problem hiding this comment.
Nice catch. I new there was something going wrong with this function but I had not looked at it yet. Thanks.
Will be merged once we fix another PR that is breaking the tests. Need to look at the tests to see why this was not being picked up.
Looked at the test. Rather simple and would not test this problem. Lets add the following test case:
matrix = np.array(
[
[1, 1, 0, 0, 1, 0, 0, 0],
[0, 0, 1, 1, 1, 1, 0, 0],
[0, 0, 0, 0, 0, 0, 1, 1],
],
dtype=np.bool_,
)
av = build_hyper_partner(matrix, 0).astype(int)
self.assertTrue
(np.array_equal([1, 1, 0, 0, 0, 0, 0, 0], av))
grace-harper
pushed a commit
that referenced
this pull request
Sep 19, 2023
Fix a small bug (#384) Co-authored-by: grace-harper <[email protected]> Update README.md (#377) Co-authored-by: grace-harper <[email protected]> Issue #247 - Replace `execute` with `backend.run()` in `qiskit-qec` (#381) * replace `execute` with `backend.run()` in `test_repetitionmatcher.py` * replace `execute` with `backend.run()` in `test_circuitmatcher.py` * replace `execute` with `backend.run()` in `test_heavy_hex_decoder.py` * replace `execute` with `backend.run()` in `faultsampler.py` * replace `execute` with `backend.run()` in `faultenumerator.py` * formatting * re-format test_repetitionmatcher.py --------- Co-authored-by: grace-harper <[email protected]> scrap
grace-harper
added a commit
that referenced
this pull request
Oct 2, 2023
Co-authored-by: grace-harper <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A small but obvious bug in
_build_hyper_partnerDetails and comments
pivot = +1should bepivot += 1